search

apache / doris

Apache Doris is an easy-to-use, high performance and unified analytics database.
https://doris.apache.org
Apache License 2.0
12.77k stars 3.28k forks source link

[fix](cluster key) fix cluster key update #44413

Open mymeiyi opened 14 hours ago

mymeiyi commented 14 hours ago

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

for mow with cluster key, update may get:

mysql> update t2_cluster_key set b = 22 where c = 2;
ERROR 1105 (HY000): errCode = 2, detailMessage = Column has no default value, column=c

Release note

None

Check List (For Author)

Check List (For Reviewer who merge this PR)

doris-robot commented 14 hours ago

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?
mymeiyi commented 14 hours ago

run buildall

doris-robot commented 13 hours ago
TPC-H: Total hot run time: 40056 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit dac608a11cf93a26d2877d94ce18edf92ba98d6b, data reload: false ------ Round 1 ---------------------------------- q1 17574 7481 7310 7310 q2 2041 180 166 166 q3 10563 1061 1138 1061 q4 10468 772 665 665 q5 7601 2688 2703 2688 q6 241 150 151 150 q7 998 634 602 602 q8 9275 1861 1873 1861 q9 6602 6424 6444 6424 q10 6982 2335 2379 2335 q11 461 268 263 263 q12 445 223 230 223 q13 18914 3043 3129 3043 q14 251 217 210 210 q15 570 525 520 520 q16 663 600 612 600 q17 1014 501 548 501 q18 7322 6848 6727 6727 q19 1351 979 952 952 q20 503 179 191 179 q21 4175 3254 3266 3254 q22 388 326 322 322 Total cold run time: 108402 ms Total hot run time: 40056 ms ----- Round 2, with runtime_filter_mode=off ----- q1 7381 7383 7337 7337 q2 331 230 233 230 q3 2890 3151 3095 3095 q4 2208 1984 1951 1951 q5 5857 5779 5851 5779 q6 236 146 150 146 q7 2351 1955 1918 1918 q8 3423 3632 3633 3632 q9 9031 8993 9051 8993 q10 3591 3598 3525 3525 q11 613 519 521 519 q12 876 630 633 630 q13 16113 3280 3241 3241 q14 306 280 284 280 q15 568 537 521 521 q16 736 656 636 636 q17 1875 1641 1601 1601 q18 8264 7807 7863 7807 q19 1688 1578 1563 1563 q20 2111 1930 1877 1877 q21 5554 5418 5320 5320 q22 641 556 581 556 Total cold run time: 76644 ms Total hot run time: 61157 ms ```
doris-robot commented 13 hours ago
TPC-DS: Total hot run time: 198064 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit dac608a11cf93a26d2877d94ce18edf92ba98d6b, data reload: false query1 1278 950 927 927 query2 6250 2095 2052 2052 query3 10800 3873 4045 3873 query4 67836 28821 23528 23528 query5 5005 464 486 464 query6 429 179 179 179 query7 5600 301 303 301 query8 324 236 216 216 query9 8986 2657 2654 2654 query10 435 255 242 242 query11 17466 15451 15986 15451 query12 159 102 102 102 query13 1533 437 417 417 query14 10968 7764 7550 7550 query15 212 194 189 189 query16 7117 476 464 464 query17 1247 568 575 568 query18 1817 298 296 296 query19 200 152 152 152 query20 135 115 114 114 query21 204 99 103 99 query22 4825 4570 4432 4432 query23 35111 34728 34571 34571 query24 5551 2481 2536 2481 query25 504 379 400 379 query26 644 154 154 154 query27 1932 293 293 293 query28 4473 2475 2468 2468 query29 700 437 411 411 query30 223 154 154 154 query31 1021 826 842 826 query32 69 54 63 54 query33 456 288 294 288 query34 944 536 544 536 query35 872 775 738 738 query36 1093 1002 976 976 query37 125 76 80 76 query38 4588 4435 4367 4367 query39 1562 1504 1491 1491 query40 207 110 103 103 query41 45 42 42 42 query42 112 100 100 100 query43 540 495 512 495 query44 1234 838 826 826 query45 196 169 167 167 query46 1168 714 725 714 query47 2058 1945 1957 1945 query48 440 327 321 321 query49 725 394 407 394 query50 868 414 412 412 query51 7506 7251 7136 7136 query52 94 89 87 87 query53 257 185 182 182 query54 525 400 396 396 query55 78 77 78 77 query56 252 259 257 257 query57 1292 1189 1173 1173 query58 224 225 236 225 query59 3173 3038 3061 3038 query60 278 250 256 250 query61 105 107 106 106 query62 799 673 672 672 query63 226 193 204 193 query64 1371 729 650 650 query65 3317 3219 3218 3218 query66 667 308 310 308 query67 15992 15768 15643 15643 query68 3912 587 554 554 query69 414 253 257 253 query70 1216 1098 1153 1098 query71 340 253 253 253 query72 6429 4107 4161 4107 query73 791 367 363 363 query74 10187 9107 9126 9107 query75 3420 2717 2697 2697 query76 1867 1079 1066 1066 query77 463 284 275 275 query78 11009 9625 9429 9429 query79 1461 589 590 589 query80 867 461 427 427 query81 527 237 227 227 query82 1238 120 123 120 query83 279 145 155 145 query84 276 72 70 70 query85 897 344 307 307 query86 334 302 282 282 query87 4828 4664 4730 4664 query88 3486 2259 2191 2191 query89 425 298 291 291 query90 1979 191 190 190 query91 136 103 102 102 query92 70 52 56 52 query93 1907 554 548 548 query94 768 290 289 289 query95 355 256 247 247 query96 616 276 276 276 query97 2900 2693 2679 2679 query98 217 212 193 193 query99 1606 1320 1310 1310 Total cold run time: 321663 ms Total hot run time: 198064 ms ```
doris-robot commented 13 hours ago
ClickBench: Total hot run time: 32.55 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit dac608a11cf93a26d2877d94ce18edf92ba98d6b, data reload: false query1 0.03 0.03 0.03 query2 0.07 0.03 0.03 query3 0.23 0.07 0.07 query4 1.64 0.10 0.11 query5 0.43 0.43 0.39 query6 1.16 0.65 0.67 query7 0.02 0.01 0.02 query8 0.04 0.03 0.02 query9 0.59 0.51 0.49 query10 0.55 0.55 0.56 query11 0.14 0.11 0.11 query12 0.14 0.11 0.11 query13 0.61 0.60 0.59 query14 2.72 2.72 2.87 query15 0.91 0.82 0.82 query16 0.39 0.37 0.39 query17 0.98 1.02 1.09 query18 0.24 0.21 0.20 query19 1.87 1.73 1.93 query20 0.01 0.01 0.01 query21 15.36 0.58 0.58 query22 2.24 2.49 1.47 query23 16.90 0.95 0.91 query24 2.99 1.19 1.52 query25 0.22 0.15 0.14 query26 0.55 0.13 0.13 query27 0.04 0.04 0.04 query28 10.38 1.09 1.06 query29 12.53 3.32 3.33 query30 0.25 0.06 0.07 query31 2.87 0.38 0.39 query32 3.28 0.46 0.47 query33 3.00 3.12 3.08 query34 16.90 4.49 4.46 query35 4.50 4.48 4.58 query36 0.66 0.49 0.47 query37 0.09 0.06 0.06 query38 0.04 0.03 0.04 query39 0.03 0.02 0.02 query40 0.16 0.13 0.13 query41 0.08 0.03 0.02 query42 0.03 0.02 0.02 query43 0.03 0.02 0.03 Total cold run time: 105.9 s Total hot run time: 32.55 s ```
mymeiyi commented 12 hours ago

run buildall

doris-robot commented 12 hours ago
TPC-H: Total hot run time: 39755 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit da462fb08ad346daa4419c177752a66a701af446, data reload: false ------ Round 1 ---------------------------------- q1 17573 7498 7336 7336 q2 2048 184 173 173 q3 10545 1139 1196 1139 q4 10211 703 782 703 q5 7626 2671 2923 2671 q6 245 148 145 145 q7 975 633 605 605 q8 9233 1864 1968 1864 q9 6570 6412 6441 6412 q10 6994 2337 2297 2297 q11 468 250 257 250 q12 434 213 217 213 q13 17758 3015 3005 3005 q14 229 220 210 210 q15 580 514 510 510 q16 642 594 586 586 q17 972 556 542 542 q18 7453 6742 6738 6738 q19 1348 982 839 839 q20 473 180 172 172 q21 3944 3038 3182 3038 q22 387 307 317 307 Total cold run time: 106708 ms Total hot run time: 39755 ms ----- Round 2, with runtime_filter_mode=off ----- q1 7265 7234 7292 7234 q2 321 221 232 221 q3 2870 2782 3061 2782 q4 2159 1908 1803 1803 q5 5583 5749 5613 5613 q6 218 137 137 137 q7 2171 1755 1791 1755 q8 3396 3595 3475 3475 q9 8863 8814 8915 8814 q10 3616 3556 3546 3546 q11 587 501 499 499 q12 849 633 606 606 q13 10735 3184 3148 3148 q14 302 273 267 267 q15 576 522 513 513 q16 687 624 627 624 q17 1790 1594 1538 1538 q18 7949 7663 7326 7326 q19 1666 1537 1608 1537 q20 2069 1846 1842 1842 q21 5412 5280 5138 5138 q22 632 532 565 532 Total cold run time: 69716 ms Total hot run time: 58950 ms ```
doris-robot commented 12 hours ago
TPC-DS: Total hot run time: 191670 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit da462fb08ad346daa4419c177752a66a701af446, data reload: false query1 975 382 377 377 query2 6528 2126 2083 2083 query3 6733 211 220 211 query4 34145 23714 23563 23563 query5 4409 456 465 456 query6 285 188 175 175 query7 4631 294 308 294 query8 286 226 230 226 query9 9544 2670 2667 2667 query10 469 244 253 244 query11 18041 15284 15238 15238 query12 155 102 115 102 query13 1650 424 401 401 query14 9786 7067 7248 7067 query15 274 170 173 170 query16 8143 460 442 442 query17 1739 553 537 537 query18 2122 312 293 293 query19 347 147 167 147 query20 120 123 109 109 query21 201 101 100 100 query22 4622 4208 4187 4187 query23 35151 34236 34161 34161 query24 10482 2371 2509 2371 query25 644 387 381 381 query26 1388 148 148 148 query27 2874 279 280 279 query28 7692 2398 2438 2398 query29 880 403 411 403 query30 302 149 151 149 query31 1048 793 819 793 query32 92 59 56 56 query33 775 283 289 283 query34 1005 496 519 496 query35 857 732 711 711 query36 1114 945 951 945 query37 142 82 77 77 query38 4408 4253 4351 4253 query39 1492 1440 1446 1440 query40 282 103 103 103 query41 51 47 47 47 query42 116 99 99 99 query43 531 496 504 496 query44 1259 804 808 804 query45 183 167 167 167 query46 1132 695 676 676 query47 1950 1871 1867 1867 query48 432 317 321 317 query49 1152 387 386 386 query50 808 376 390 376 query51 7209 7078 7143 7078 query52 106 88 87 87 query53 254 176 181 176 query54 1253 399 399 399 query55 83 77 77 77 query56 269 244 240 240 query57 1325 1208 1153 1153 query58 263 211 220 211 query59 3212 3008 3177 3008 query60 262 256 247 247 query61 118 109 111 109 query62 878 682 697 682 query63 212 184 185 184 query64 5321 653 617 617 query65 3304 3264 3227 3227 query66 1447 323 321 321 query67 16196 15926 15826 15826 query68 3547 581 561 561 query69 420 257 261 257 query70 1178 1140 1145 1140 query71 326 255 244 244 query72 6191 4059 4007 4007 query73 787 361 362 361 query74 10009 9110 9124 9110 query75 3442 2669 2653 2653 query76 2489 1149 1072 1072 query77 368 267 284 267 query78 10391 9494 9496 9494 query79 1137 589 585 585 query80 821 439 432 432 query81 533 230 234 230 query82 1255 117 122 117 query83 242 150 148 148 query84 236 68 71 68 query85 1153 376 371 371 query86 319 291 292 291 query87 4809 4617 4477 4477 query88 3555 2234 2206 2206 query89 401 296 304 296 query90 2173 182 183 182 query91 137 102 101 101 query92 59 50 51 50 query93 1079 519 539 519 query94 798 297 293 293 query95 349 251 247 247 query96 613 289 278 278 query97 2881 2707 2719 2707 query98 214 191 193 191 query99 1521 1316 1302 1302 Total cold run time: 298592 ms Total hot run time: 191670 ms ```
doris-robot commented 12 hours ago
ClickBench: Total hot run time: 33.11 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit da462fb08ad346daa4419c177752a66a701af446, data reload: false query1 0.04 0.03 0.02 query2 0.07 0.03 0.03 query3 0.23 0.06 0.06 query4 1.62 0.10 0.11 query5 0.41 0.40 0.41 query6 1.17 0.66 0.65 query7 0.02 0.01 0.02 query8 0.04 0.03 0.03 query9 0.59 0.51 0.51 query10 0.54 0.56 0.55 query11 0.14 0.11 0.11 query12 0.14 0.12 0.11 query13 0.60 0.60 0.60 query14 2.81 2.78 2.85 query15 0.90 0.82 0.83 query16 0.37 0.38 0.39 query17 1.08 1.08 1.05 query18 0.23 0.21 0.20 query19 1.97 1.88 1.99 query20 0.01 0.01 0.02 query21 15.36 0.59 0.58 query22 2.60 2.14 1.62 query23 16.96 0.88 0.80 query24 3.12 1.46 1.49 query25 0.20 0.22 0.16 query26 0.54 0.14 0.14 query27 0.04 0.04 0.05 query28 9.85 1.10 1.08 query29 12.57 3.31 3.33 query30 0.25 0.06 0.06 query31 2.87 0.39 0.39 query32 3.25 0.47 0.46 query33 3.00 3.03 3.11 query34 16.97 4.44 4.45 query35 4.65 4.47 4.46 query36 0.68 0.48 0.48 query37 0.09 0.06 0.06 query38 0.04 0.04 0.03 query39 0.03 0.02 0.02 query40 0.16 0.12 0.12 query41 0.08 0.02 0.03 query42 0.03 0.02 0.02 query43 0.04 0.03 0.03 Total cold run time: 106.36 s Total hot run time: 33.11 s ```
github-actions[bot] commented 9 hours ago

PR approved by at least one committer and no changes requested.

github-actions[bot] commented 9 hours ago

PR approved by anyone and no changes requested.