search

apache / doris

Apache Doris is an easy-to-use, high performance and unified analytics database.
https://doris.apache.org
Apache License 2.0
12.27k stars 3.2k forks source link

support clang-format and clang-tidy #4918

Open chaoyli opened 3 years ago

chaoyli commented 3 years ago

Doris is short for static code format and check, it's better to add clang-format and clang-tidy. I will add some clang-format and clang-tidy in the following patch

sduzh commented 3 years ago

Doris考虑先一次性把整个仓库format一下吗? @kangkaisen @chaoyli @imay @morningman

morningman commented 3 years ago

Doris考虑先一次性把整个仓库format一下吗? @kangkaisen @chaoyli @imay @morningman

I think we can do it step by step. Format the entire code base in one time it not easy for review and code rebase.

sduzh commented 3 years ago

Doris考虑先一次性把整个仓库format一下吗? @kangkaisen @chaoyli @imay @morningman

I think we can do it step by step. Format the entire code base in one time it not easy for review and code rebase.

IMHO, formatting the whole codebase at once would be more friendly for other contributors, since they can just focus on their newly added code.

yangzhg commented 3 years ago

fe unittest may also be formate and tidy at this time