apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.93k stars 980 forks source link

[MINOR-UPDATE]: Drop conjars repo and revert ci.yml runner image to ubuntu-latest #2782

Closed jnturton closed 1 year ago

jnturton commented 1 year ago
Lceeba commented 1 year ago

Unsubscribe

On Thu, 30 Mar, 2023, 14:16 James Turton, @.***> wrote:

  1. Adds the mentioned examples as a follow up to DRILL-8409.
  2. Tests whether the GitHub Runner image regression in ubuntu-latest has been fixed by their new image update.

You can view, comment on, or merge this pull request online at:

https://github.com/apache/drill/pull/2782 Commit Summary

File Changes

(2 files https://github.com/apache/drill/pull/2782/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/apache/drill/pull/2782, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZFXPU23WZIDLQDABJKRT3W6VB7LANCNFSM6AAAAAAWM65TTE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jnturton commented 1 year ago

It looks like the CI runs failed because conjars is unable to serve all the requests it's getting at the moment. I'm not sure whether to wait before trying again...

jnturton commented 1 year ago

I guess we'll just have to try kicking the CI off again tomorrow to get confirmation that the ubuntu-latest works and should be merged.

jnturton commented 1 year ago

@cgivre this can subsume #2785 .

rymarm commented 1 year ago

@jnturton I've checked my local maven repository and found that there are only 2 dependencies that were downloaded from conjars repository:

$ for file in `find ~/.m2/repository/ -name "_remote.repositories"`; do grep $file -e "conjars"; done
pentaho-aggdesigner-5.1.5-jhyde.pom>conjars=
pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom>conjars=
pentaho-aggdesigner-algorithm-5.1.5-jhyde.jar>conjars=

But neither is used in Drill now. So yea, we can just remove redundant conjars repo.

jnturton commented 1 year ago

Thanks for checking @rymarm .