apache / drill

Apache Drill is a distributed MPP query layer for self describing data

https://drill.apache.org/

Apache License 2.0

1.93k stars 980 forks source link

DRILL-8420: Remove Guava shading and patching #2786

Closed jnturton closed 1 year ago

jnturton commented 1 year ago

DRILL-8420: Remove Guava shading and patching.

Description

Based on #2782 to enable a clean CI run.

Remove shaded Guava.
Drop Guava patches.
Upgrade guava to 31.1-jre.

Documentation

N/A

Testing

Existing unit tests.

cgivre commented 1 year ago

@jnturton Thanks for this. Aside from imports, which files were actually modified and I'll do a review?

cgivre commented 1 year ago

Do we want to add this to back port to stable?

jnturton commented 1 year ago

@cgivre

Thanks for this. Aside from imports, which files were actually modified and I'll do a review?

Yes, I'll split the import statement changes into a separate commit.

Do we want to add this to back port to stable?

I don't think so. It's not a fix and it definitely carries a risk of breakage with it. Currently the Hadoop 2 build is broken because Drill's Guava patches (but not shading) are still needed in that case so I'll set the PR to draft for the moment.

cgivre commented 1 year ago

@jnturton Is this PR still relevant?

jnturton commented 1 year ago

@jnturton Is this PR still relevant?

Yes, I'm going to resurrect it after all the other clean up and upgrade PRs are in.