Describe the bug
The code contains multiple x < ... checks where x is a byte and the right-hand side is > 127 (= max byte value), so these conditions are always true:
Not completely sure what the fix here is, maybe (byte & 0xFF) < .... And also for StringFunctions maybe it should be 128 (decimal) instead of 0x128 (hex, = 296 decimal); at least the 0x128 looks a bit suspicious.
Describe the bug The code contains multiple
x < ...
checks wherex
is abyte
and the right-hand side is > 127 (= maxbyte
value), so these conditions are always true:Not completely sure what the fix here is, maybe
(byte & 0xFF) < ...
. And also forStringFunctions
maybe it should be128
(decimal) instead of0x128
(hex, = 296 decimal); at least the0x128
looks a bit suspicious.