search

apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.93k stars 980 forks source link

DRILL-8430: Create JacksonUtils #2800

Closed pjfanning closed 1 year ago

pjfanning commented 1 year ago

Description

Shared utility methods for Jackson

Documentation

N/A

Testing

Ran existing unit tests.

cgivre commented 1 year ago

@pjfanning There is an issue with Calcite 1.35-SNAPSHOT that is causing TestTimestampAddDiffFunctions.testTimestampAddDiffLiteralTypeInference to fail. This has nothing to do with this PR. Would you mind putting an @Ignore with a note on that unit test until we fix it so that we can test this PR?

cgivre commented 1 year ago

@pjfanning Sorry for the repeated comments yesterday. Github was giving me an error message and it didn't look like the comment had actually posted.

pjfanning commented 1 year ago

@cgivre no worries - I had timeout and other issues with GitHub around that time too. Some sort of general GitHub health issues, I guess.

cgivre commented 1 year ago

@jnturton Can we merge this?