apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.93k stars 980 forks source link

[MINOR UPDATE] Bump YAUAA to 7.19.2 #2807

Closed cgivre closed 1 year ago

cgivre commented 1 year ago

[MINOR UPDATE]: Bump YAUAA to 7.19.2

Description

Bump YAUAA to 7.19.2

Documentation

No user facing changes.

Testing

Ran unit tests.

cgivre commented 1 year ago

@nielsbasjes Could you assist with this? I tried removing the exclusion and am still getting the same error.

nielsbasjes commented 1 year ago

[I'm ignoring the "Network is unreachable" problem because I cannot help with that].

Some background: The Yauaa jar is now a MultiRelease jar that at runtime automatically selects the correct caching implementation. So running in Java 8 it will use a basic LRUMap and when running in Java 11+ it will use Caffeine. This is the reason why this error only is visible under Java 11 and 17 and not under 8.

What I understand right now: Building and running on Java 11 and 17 fails with java.lang.NoClassDefFoundError: com/github/benmanes/caffeine/cache/Caffeine because that has been excluded.

I'm going to do a local test to see if I can reproduce this specific problem and look for a way to fix it.

nielsbasjes commented 1 year ago

Found it ... works on my machine; See this pull request https://github.com/apache/drill/pull/2808 for my proposed changes.

cgivre commented 1 year ago

Thanks @nielsbasjes ! I'm going to close this PR.