apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.93k stars 980 forks source link

DRILL-8451: options and profile pages have bad order symbols style #2820

Closed rymarm closed 1 year ago

rymarm commented 1 year ago

DRILL-8451: options and profile pages have bad order symbols style

Description

"Options" and "Profile" pages have bad order symbols style:

Current: зображення зображення

Expected: зображення

"Options" and "Profile" pages were using Drill own sorting symbols styling instead of dataTables style that is used on all other pages. I've removed outdated black-asc.gif, black-dsc.gif, black-unsorted.gif sorting symbols, and replaced them with dataTable styled symbols.

I also disabled sorting for "value" and "description" columns on "Options" page. Sorting on "value" doesn't work properly due to different types of values, and sorting on the "description" column is just redundant.

Options page

before: зображення

after: зображення

Profile page

before: зображення

after: зображення

Documentation

None requerid

Testing

Visual check of UI in Firefox and Edge browsers.

cgivre commented 1 year ago

@rymarm Would you mind please rebasing on current master? There's now a merge conflict as a result of your other PR.

rymarm commented 1 year ago

@cgivre Sure! Done.