apache / drill

Apache Drill is a distributed MPP query layer for self describing data

https://drill.apache.org/

Apache License 2.0

1.93k stars 984 forks source link

DRILL-8454: Disable unsupported MapR profile and plugin #2825

Closed jnturton closed 9 months ago

jnturton commented 11 months ago

DRILL-8454: Disable unsupported MapR profile and plugin

Description

The MapR build profile and format plugin, which fell out of support in the open source Drill codebase years ago, are disabled. Drill users needing support for these components should contact HPE.

Documentation

See the HPE Ezmeral docs.

Testing

Build and unit tests of remaining modules pass.

jnturton commented 11 months ago

This one's ready for review.

jnturton commented 11 months ago

A note to the reviewers. Git's default diff algorithm makes it very hard to see that the changes this PR makes to pom.xml are simply whole sections moving into comment blocks. GitHub does not allow users to select the diff algorithm at this time so, to ease review, I have therefore uploaded the diff of pom.xml generated using git diff --diff-algorithm=patience separately as a Gist. It is of course also possible to produce the same locally after pulling down my branch.

rymarm commented 10 months ago

@jnturton Hi! I'll take a look at this pull request this week later or even next week. I've just got back from a vacation and got on a "burning boat" of work)

But I have a question now, Why did you decide to comment the mapr specific changes, but not completely remove them?

And in addition, I suppose that we also need to remove mentions of maprdb support from the documentation or leave a link to HPE documentation.

jnturton commented 10 months ago

@rymarm welcome back! I wasn't sure whether to delete or comment out the mapr modules. I decided to try moving them to new, commented out sections of "Objects of type foo that are no longer supported" that seemed to keep an informative history in the source files without a lot of extra cruft. But that history is always available in Git so I'm also happy to delete instead...

cgivre commented 9 months ago

@jnturton Can we merge this?

jnturton commented 9 months ago

@cgivre let me convert the comment blocks to deletions as suggested by you and @rymarm and then let's merge it.

jnturton commented 9 months ago

@cgivre let me convert the comment blocks to deletions as suggested by you and @rymarm and then let's merge it.

Done...