apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.93k stars 979 forks source link

DRILL-8446: Incorrect use of OperatingSystemMXBean #2843

Closed jnturton closed 11 months ago

jnturton commented 11 months ago

DRILL-8446: Incorrect use of OperatingSystemMXBean

Description

Simplify CpuGaugeSet fixing the non-Sun/Oracle code path in the process.

The com.sun.management internal implementation of OperatingSystemMXBean is used by Drill to report a CPU metric that is not available in the public interface. Even though code to handle non-Sun/Oracle runtimes for the OperatingSystemMXBean was present, it would still cause them to attempt to load a class from com.sun.management causing a NoClassDefFoundError.

Documentation

N/A

Testing

Launch Drill and check the affected gauges in

jnturton commented 11 months ago

LGTM +1

@jnturton Does this fix the Splunk flaky test?

Hopefully.