apache / drill

Apache Drill is a distributed MPP query layer for self describing data

https://drill.apache.org/

Apache License 2.0

1.93k stars 984 forks source link

[DRAFT] Update Calcite to 1.36 #2844

Closed cgivre closed 6 months ago

cgivre commented 9 months ago

DRILL-XXXX: Update Calcite to 1.35

(Please replace PR Title with actual PR Title)

Description

(Please describe the change. If more than one ticket is fixed, include a reference to those tickets.)

Documentation

(Please describe user-visible changes similar to what should appear in the Drill documentation.)

Testing

(Please describe how this PR has been tested.)

cgivre commented 9 months ago

@vvysotskyi @jnturton, I started experimenting with updating to Calcite 1.35 and there's some strange behavior that I could use some assistance with. Basically, for DECIMAL(), Calcite seems to be reversing the scale and precision. I'm not quite sure even where to start with this. Could you point me in the right direction?

vvysotskyi commented 9 months ago

@cgivre, I think to fix it there are required changes in DrillRexBuilder.makeCast to accept and pass further boolean safe param. Here are some of my changes for update I tried long time ago: https://github.com/apache/drill/compare/master...vvysotskyi:drill:calcite-1.35-test