apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.93k stars 979 forks source link

elasticsearch storage is not correctly saved #2856

Closed darkattractions closed 10 months ago

darkattractions commented 10 months ago

Before submitting a bug report, please verify that you are using the most current version of Drill.

Describe the bug When creating a plugin storage for elastic search, the property hosts is not saved at all.

To Reproduce Steps to reproduce the behavior:

  1. in webUI, create a plugin storage with
    {
    "type": "elastic",
    "hosts": ["http://localhost"],
    "authMode": "SHARED_USER"
    }
  2. save it
  3. update it
  4. the line hosts has disappeared

Expected behavior hosts to be saved

Drill version version 1.20.3 works. Version 1.21.0 and 1.21.1 failed.

Additional context Add any other context about the problem here.

cgivre commented 10 months ago

I think this issue may have been fixed in this PR: https://github.com/apache/drill/pull/2797. I'm not sure if it is a part of Drill 1.21.1. Can you build 1.22-SHAPSHOT and see if the problem persists?

darkattractions commented 10 months ago

I built 1.22-SNAPHOT and the problem is over. When can I expect this version to be official ?

cgivre commented 10 months ago

We've been talking about putting out a new release soon. We're waiting for https://github.com/apache/drill/pull/2836 to be merged, but we could cut a maintenance release. @jnturton, @mbeckerle What do you guys think?

mbeckerle commented 10 months ago

We've been talking about putting out a new release soon. We're waiting for #2836 to be merged, but we could cut a maintenance release. @jnturton, @mbeckerle What do you guys think?

This daffodil+drill stuff should stay on a branch, and not become part of a next drill release, as it depends on new Daffodil features not yet part of an official release of Daffodil.

I hope to restart work on drill+daffodil in the next day or two.