search

apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.95k stars 979 forks source link

DRILL-8475: Update the binary distributions LICENSE #2879

Closed jnturton closed 8 months ago

jnturton commented 9 months ago

DRILL-8475: Update the binary distributions LICENSE

Description

The LICENSE file included in the binary distributions of Drill becomes an artifact that is generated automatically by the org.codehaus.mojo:license-maven-plugin (and so is no longer part of the Git source tree). The generated LICENSE is therefore profile dependent, e.g. the Hadoop 2 build of Drill will (as it must) carry a different LICENSE file. Dependencies that it cannot detect are kept in the LICENSE-base.txt file which is combined with the generated license notices by a new Freemarker template. Various other dependency related changes are included as part of this work. It is still possible that fat jars have introduced hidden depedencies but I propose that those are analysed in a subsequent Jira issue.

Documentation

Comments and updated dev docs.

Testing

Comparison of the jars/ directory of a Drill build against the generated LICENSE file to check that every bundled jar has a license notice in LICENSE. The generated Hadoop 3 LICENSE at the time of writing is attached, the new content appearing after the Apache 2.0 license itself.

Connect to Drill using the pruned JDBC driver wuth TLS enabled and search inside the driver JAR for any references to the pruned dependencies.

LICENSE.txt

jnturton commented 9 months ago

TODO: determine whether too much has been pruned from the JDBC driver, specifically libraries related to Kerberos.

cgivre commented 9 months ago

@jnturton Are we closed to merging this?