search

apache / drill

Apache Drill is a distributed MPP query layer for self describing data
https://drill.apache.org/
Apache License 2.0
1.95k stars 979 forks source link

[MINOR UPDATE] update to netty 4.1.109 due to CVE-2024-29025 #2904

Closed pjfanning closed 7 months ago

pjfanning commented 7 months ago

CVE-2024-29025

Update to latest versions regardless

pjfanning commented 7 months ago

This is causing a compile problem because Drill has some classes of its own that try to get inside the netty internals. The netty inner state has changed.

Error:  /home/runner/work/drill/drill/exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java:[112,38] error: cannot find symbol
  symbol:   variable chunkSize
  location: class PoolArena<ByteBuffer>
Error:  /home/runner/work/drill/drill/exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java:[169,41] error: cannot find symbol
  symbol:   variable chunkSize
  location: variable directArena of type PoolArena<ByteBuffer>
cgivre commented 7 months ago

@pjfanning Are the issues with this resolved?

pjfanning commented 7 months ago

@cgivre I fixed the compile issue and the tests seem to pass.