apache / druid

Apache Druid: a high performance real-time analytics database.
https://druid.apache.org/
Apache License 2.0
13.29k stars 3.66k forks source link

remove native scan query legacy mode #16659

Open clintropolis opened 5 days ago

clintropolis commented 5 days ago

Description

The native scan query was moved from a contrib extension into core in Druid 0.11 in #4751, which introduced a 'legacy' option to maintain backwards compatibility with the extension, which used a non-standard time column name and always included this timestamp in the results.

I think sufficient time has passed to allow us to remove this parameter to help simplify code a bit.

Release note

The native scan query 'legacy' mode has been removed, which was introduced in Druid 0.11 to maintain compatibility during an upgrade from older versions of Druid where the scan query was part of a 'contrib' extension.


This PR has:

clintropolis commented 4 days ago

CI failures are related to coverage, which I guess means this stuff wasn't well covered in the first place since I am only removing stuff in this PR. Can look into maybe adding some more tests to get it happy, but also doesn't really feel like a blocker

kgyrtkirk commented 4 days ago

oh...covereage change issues have prevented further tests from being run... or somehow re-organize the maven target order... I think there should be a way to disable that; this is a perfect example - there were issues arising from that earlier

In this case I think that doesn't really apply as these jobs were running with -pl processing already - but coverage issues are evil when they happen in the other modules splits