Revert "always set taskLocation (#17350)"

georgew5656 commented 1 month ago

This reverts commit a664fc8be3cdba479caed7ebd49ef2f835bf7699.

Description

The reverted commit can cause issues when overlords with a lot of tasks restart because of the flood of calls to k8s. This also combines with another bug when saveLogs() is called with a running task that causes the task to get stuck in a pending state.

I'm planning on fixing the saveLogs bug in a separate PR + address the original issue this commit tried to fix with a different approach, but for now reverting this change because it seems to cause more issues than it solves.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

fix a bug during overlord restarts introduced by the previous change

Key changed/added classes in this PR

KubernetesPeonLifecyle

This PR has:

[X] been self-reviewed.
- [ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[X] been tested in a test Druid cluster.

suneet-s commented 1 month ago

Reverts #17350

georgew5656 commented 1 month ago

will address this issue in https://github.com/apache/druid/pull/17419/files#diff-bb902bcc2fa097a13509038cd5ae6987b355c2bcf50f7a558bf9c1a3f5d521db

apache / druid