apache / druid

Apache Druid: a high performance real-time analytics database.
https://druid.apache.org/
Apache License 2.0
13.52k stars 3.71k forks source link

ManageLifecycle DropwizardEmitter instantiation #17451

Closed abhishekrb19 closed 2 weeks ago

abhishekrb19 commented 2 weeks ago

Problem

Fixes the issue reported in https://apachedruidworkspace.slack.com/archives/C030CMF6B70/p1730782496492849.

java.util.concurrent.RejectedExecutionException: Dropwizard emitter Service not started.
        at org.apache.druid.emitter.dropwizard.DropwizardEmitter.emit(DropwizardEmitter.java:96) ~[?:?]
        at org.apache.druid.java.util.emitter.core.ComposingEmitter.emit(ComposingEmitter.java:57) ~[druid-processing-27.0.0.3.2.2.0-1.jar:27.0.0.3.2.2.0-1]
        at org.apache.druid.java.util.emitter.service.ServiceEmitter.emit(ServiceEmitter.java:67) ~[druid-processing-27.0.0.3.2.2.0-1.jar:27.0.0.3.2.2.0-1]
        at org.apache.druid.java.util.emitter.service.ServiceEmitter.emit(ServiceEmitter.java:72) ~[druid-processing-27.0.0.3.2.2.0-1.jar:27.0.0.3.2.2.0-1]

Fix

Without the ManageLifecycle annotation, an instance of the emitter will be instantiated without proper initialization. Having the dropwizard emitter on the ManageLifecycle ensures that an instance of the emitter gets registered with the lifecycle such that it starts doing things based on start() & stop() from the lifecycle. The alternative would be to use the LazySingleton scope but ManageLifecycle is what all the other emitter implementations do.

Release note

Fixes an issue with the dropwizard emitter instantiation, where the emitter starts up without proper initialization thereby bringing down Druid processes.

This PR has: