The above project isn't being actively maintained.
We also have other checks (like maven-checkstyle-plugin and spotbugs) integrated in our CI pipeline which makes the intellij-inspections check redundant for the most part.
On further looking into point (4), the intellij-inspections check does seem to provide some useful checks which aren't being covered in other static checks we have at the moment.
So the plan is:
Remove intellij-inspections check.
Remove Java 8 support.
Explore other options like Qodana and integrate them in the repo as a replacement for intellij-inspections check.
This PR has:
[x] been self-reviewed.
[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
Description
We plan to deprecate Java 8 as part of #17466. We ran into some issues with
intellij-inspections
check while doing that.On further discussion, we decided that we should remove intellij-inspections check for the following reasons:
intellij-inspections
is coming from https://github.com/ccaominh/intellij-inspect, which is tied down toopenjdk8
image.intellij-inspect
is published at https://hub.docker.com/r/ccaominh/intellij-inspect, which is outside of Apache infra.maven-checkstyle-plugin
andspotbugs
) integrated in our CI pipeline which makes theintellij-inspections
check redundant for the most part.On further looking into point (4), the
intellij-inspections
check does seem to provide some useful checks which aren't being covered in other static checks we have at the moment.So the plan is:
intellij-inspections
check.intellij-inspections
check.This PR has: