apache / druid

Apache Druid: a high performance real-time analytics database.
https://druid.apache.org/
Apache License 2.0
13.53k stars 3.71k forks source link

Remove `intellij-inspections` check from CI #17469

Closed Akshat-Jain closed 2 weeks ago

Akshat-Jain commented 2 weeks ago

Description

We plan to deprecate Java 8 as part of #17466. We ran into some issues with intellij-inspections check while doing that.

On further discussion, we decided that we should remove intellij-inspections check for the following reasons:

  1. intellij-inspections is coming from https://github.com/ccaominh/intellij-inspect, which is tied down to openjdk8 image.
  2. The image for intellij-inspect is published at https://hub.docker.com/r/ccaominh/intellij-inspect, which is outside of Apache infra.
  3. The above project isn't being actively maintained.
  4. We also have other checks (like maven-checkstyle-plugin and spotbugs) integrated in our CI pipeline which makes the intellij-inspections check redundant for the most part.

On further looking into point (4), the intellij-inspections check does seem to provide some useful checks which aren't being covered in other static checks we have at the moment.

So the plan is:

  1. Remove intellij-inspections check.
  2. Remove Java 8 support.
  3. Explore other options like Qodana and integrate them in the repo as a replacement for intellij-inspections check.

This PR has:

cryptoe commented 2 weeks ago

Why do we need to remove these files

Folks should be able to run intellij inspections locally if they want to.