Open jtuglu-netflix opened 2 weeks ago
This PR provides enhances JVM GC metrics to the JvmMonitor monitor. Namely:
JvmMonitor
jvm/gc/pause
jvm/gc/concurrentTime
Pulls GC event subscription logic from https://github.com/Netflix/spectator. I'm wondering whether more metrics from this list: https://netflix.github.io/atlas-docs/spectator/lang/java/ext/jvm-gc/#jvmgcpause – we currently take aggregate statistics from getMemoryPoolMXBeans() on total mem usage, etc. via GcSpaceCollector.
GcSpaceCollector
Adds jvm/gc/pause and jvm/gc/concurrentTime metrics to JvmMonitor.
docs/operations/metrics.md
processing/src/main/java/org/apache/druid/java/util/metrics/EventBuffer.java
processing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitor.java
processing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitorConfig.java
processing/src/main/java/org/apache/druid/java/util/metrics/Monitors.java
processing/src/main/java/org/apache/druid/java/util/metrics/jvm/gc/GcEvent.java
processing/src/test/java/org/apache/druid/java/util/metrics/EventBufferTest.java
processing/src/test/java/org/apache/druid/java/util/metrics/JvmMonitorTest.java
processing/src/test/java/org/apache/druid/java/util/metrics/MonitorsTest.java
server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java
This PR has:
This PR provides enhances JVM GC metrics to the
JvmMonitormonitor. Namely:jvm/gc/pause: Stop-the-world garbage collection JVM-reported pause time (ms)jvm/gc/concurrentTime: JVM-reported time spent in concurrent phases of CMS pauses (ms)Description
Pulls GC event subscription logic from https://github.com/Netflix/spectator. I'm wondering whether more metrics from this list: https://netflix.github.io/atlas-docs/spectator/lang/java/ext/jvm-gc/#jvmgcpause – we currently take aggregate statistics from getMemoryPoolMXBeans() on total mem usage, etc. via
GcSpaceCollector.Release note
Adds
jvm/gc/pauseandjvm/gc/concurrentTimemetrics to JvmMonitor.Key changed/added classes in this PR
docs/operations/metrics.mdprocessing/src/main/java/org/apache/druid/java/util/metrics/EventBuffer.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitor.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitorConfig.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/Monitors.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/jvm/gc/GcEvent.javaprocessing/src/test/java/org/apache/druid/java/util/metrics/EventBufferTest.javaprocessing/src/test/java/org/apache/druid/java/util/metrics/JvmMonitorTest.javaprocessing/src/test/java/org/apache/druid/java/util/metrics/MonitorsTest.javaserver/src/main/java/org/apache/druid/server/metrics/MetricsModule.javaThis PR has: