AlbumenJ commented 1 year ago

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1014 (2442dfe) into refactor-with-go (1195b4d) will increase coverage by 25.66%. The diff coverage is 69.86%.

@@                  Coverage Diff                  @@
##           refactor-with-go    #1014       +/-   ##
=====================================================
+ Coverage             32.21%   57.88%   +25.66%     
=====================================================
  Files                     9       14        +5     
  Lines                  1164     1097       -67     
=====================================================
+ Hits                    375      635      +260     
+ Misses                  757      427      -330     
- Partials                 32       35        +3

Impacted Files	Coverage Δ
pkg/authority/v1alpha1/ca_grpc.pb.go	`0.00% <ø> (ø)`
pkg/authority/v1alpha1/rule.go	`0.00% <0.00%> (ø)`
pkg/authority/v1alpha1/ca.pb.go	`10.00% <16.66%> (+2.70%)`	:arrow_up:
pkg/authority/rule/connection/storage.go	`33.59% <33.59%> (ø)`
pkg/authority/cert/util.go	`75.33% <42.85%> (-2.22%)`	:arrow_down:
pkg/authority/cert/storage.go	`77.77% <50.00%> (ø)`
pkg/authority/security/server.go	`66.11% <74.35%> (+8.27%)`	:arrow_up:
pkg/authority/v1alpha1/tools.go	`82.60% <82.60%> (ø)`
pkg/authority/rule/authentication/rule.go	`90.47% <90.47%> (ø)`
pkg/authority/rule/authorization/rule.go	`90.47% <90.47%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1195b4d...2442dfe. Read the comment docs.