apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

dubboctl initial phase #1025

Closed DMwangnima closed 1 year ago

DMwangnima commented 1 year ago

What is the purpose of the change

dubboctl initial phase based on istioctl design and original dubbo-cli source code.

Brief changelog

  1. code entrance: dubboctl/cmd/manifest.go
  2. main code packages: dubboctl/internal/apis, dubboctl/internal/controlplane, dubboctl/internal/manifest, dubboctl/internal/util, deploy/profiles
  3. For now, I finished zookeeper aspect of DubboOperator and manifest generate cmd. If this POC works, I plan to finish the other charts step by step and implement manifest install cmd based on generate cmd.

Verifying this change

See dubboctl/cmd/manifest_test.go, it shows a simple performing link of manifest generate cmd.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1025 (3b16f46) into refactor-with-go (00b2d05) will decrease coverage by 9.71%. The diff coverage is 26.89%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1025      +/-   ##
====================================================
- Coverage             67.07%   57.36%   -9.71%     
====================================================
  Files                    15       28      +13     
  Lines                  1227     1724     +497     
====================================================
+ Hits                    823      989     +166     
- Misses                  364      651     +287     
- Partials                 40       84      +44     
Impacted Files Coverage Δ
pkg/dubboctl/internal/cmd/install.go 0.00% <0.00%> (ø)
pkg/dubboctl/internal/manifest/tree.go 13.77% <13.77%> (ø)
pkg/dubboctl/internal/manifest/common.go 15.55% <15.55%> (ø)
pkg/dubboctl/internal/manifest/util.go 17.94% <17.94%> (ø)
pkg/dubboctl/cmd/show.go 19.04% <19.04%> (ø)
pkg/dubboctl/cmd/gen.go 22.22% <22.22%> (ø)
pkg/dubboctl/cmd/new_demo.go 22.22% <22.22%> (ø)
pkg/dubboctl/cmd/hessian.go 23.80% <23.80%> (ø)
pkg/dubboctl/cmd/install.go 29.54% <29.54%> (ø)
pkg/dubboctl/internal/cmd/manifest.go 33.33% <33.33%> (ø)
... and 5 more

... and 5 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information