feat: refactor the tag route feature with go

seriouszyx commented 1 year ago

What is the purpose of the change

Fix: https://github.com/apache/dubbo-admin/issues/1029 Refactor the tag route feature with go

Verifying this change

Verify by postman:

CreateRule:

curl -X POST \
  http://127.0.0.1:38080/api/dev/rules/route/tag \
  -H 'cache-control: no-cache' \
  -d '{"configVersion":"v3.0","force":true,"enabled":true,"key":"shop-detail","tags":[{"name":"gray","match":[{"key":"env","value":{"exact":"gray"}}]}],"application":"my-app1"}'

UpdateRule:

curl -X PUT \
  http://127.0.0.1:38080/api/dev/rules/route/tag/my-app1 \
  -H 'cache-control: no-cache' \
  -d '{"configVersion":"v3.1","force":true,"enabled":true,"key":"shop-detail","tags":[{"name":"gray","match":[{"key":"env","value":{"exact":"gray"}}]}],"application":"my-app1"}'

SearchRoutes:

curl -X GET \
  'http://127.0.0.1:38080/api/dev/rules/route/tag?application=my-app1' \
  -H 'cache-control: no-cache' \

DetailRoute:

curl -X GET \
  http://127.0.0.1:38080/api/dev/rules/route/tag/my-app1 \
  -H 'cache-control: no-cache' \

DeleteRoute:

curl -X DELETE \
  http://127.0.0.1:38080/api/dev/rules/route/tag/my-app1 \
  -H 'cache-control: no-cache' \

EnableRoute:

curl -X PUT \
  http://127.0.0.1:38080/api/dev/rules/route/tag/enable/my-app1 \
  -H 'cache-control: no-cache' \

DisableRoute:

curl -X PUT \
  http://127.0.0.1:38080/api/dev/rules/route/tag/disable/my-app1 \
  -H 'cache-control: no-cache' \

Issues to be fixed

The added unit test relies on the zookeeper environment, so the CI fails.
The Update API returns the error "zk: node already exists", which should be caused by the PublishConfig func of the dubbo-go implementation.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

AlbumenJ commented 1 year ago

Please fix conflicts

seriouszyx commented 1 year ago

Please fix conflicts

done

codecov-commenter commented 1 year ago

Codecov Report

Merging #1030 (0136bf6) into refactor-with-go (ca77afa) will decrease coverage by 2.07%. The diff coverage is 8.43%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1030      +/-   ##
====================================================
- Coverage             67.08%   65.02%   -2.07%     
====================================================
  Files                    25       27       +2     
  Lines                  1905     1967      +62     
====================================================
+ Hits                   1278     1279       +1     
- Misses                  533      593      +60     
- Partials                 94       95       +1

Impacted Files	Coverage Δ
pkg/admin/services/tag_route_service_impl.go	`0.00% <0.00%> (ø)`
pkg/admin/util/base_service_metadata.go	`0.00% <0.00%> (ø)`
pkg/admin/util/yaml_parser.go	`71.42% <71.42%> (ø)`
pkg/admin/services/override_service_impl.go	`48.88% <100.00%> (ø)`