apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

feat: refactor dynamic config with go #1032

Closed ev1lQuark closed 1 year ago

ev1lQuark commented 1 year ago

What is the purpose of the change

Refactor the full functionality of dynamic configuration with Go.

Brief changelog

Verifying this change

XXX

Follow this checklist to help us incorporate your contribution quickly and easily:

codecov-commenter commented 1 year ago

Codecov Report

Merging #1032 (2ca4398) into refactor-with-go (55789ff) will decrease coverage by 19.86%. The diff coverage is 53.38%.

@@                  Coverage Diff                  @@
##           refactor-with-go    #1032       +/-   ##
=====================================================
- Coverage             84.15%   64.29%   -19.86%     
=====================================================
  Files                    15       24        +9     
  Lines                  1199     1840      +641     
=====================================================
+ Hits                   1009     1183      +174     
- Misses                  147      578      +431     
- Partials                 43       79       +36     
Impacted Files Coverage Δ
pkg/admin/services/override_service_impl.go 48.88% <48.88%> (ø)
pkg/admin/util/override_utils.go 92.30% <92.30%> (ø)

... and 9 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information