Refactor authority startup with cobra and viper

2456868764 commented 1 year ago

What is the purpose of the change

Brief changelog

change authority command line flags style as follow:

./authority --help The authority app is responsible for controllers in dubbo authority

Usage: authority [flags]

Flags: --debug-port int dubbo debug port (default 30070) --enable-oidc-check dubbo enable OIDC check -h, --help help for authority --in-pod-env dubbo run in pod environment --is-kubernetes-connected dubbo connected with kubernetes --kubeconfig string Paths to a kubeconfig. Only required if out-of-cluster. --namespace string dubbo namespace (default "dubbo-system") --plain-server-port int dubbo plain server port (default 30060) --secure-server-port int dubbo secure server port (default 30062) --service-name string dubbo service name (default "dubbo-ca") --webhook-allow-on-err dubbo webhook allow on error (default true) --webhook-port int32 dubbo webhook port (default 30080)

Read command line flags from Env variables, which are prefixed with DUBBO , for example

DUBBO_PLAIN_SERVER_PORT

Change k8s client init rest.config

       `// Read kubeconfig from command line
if len(kubeconfig) <= 0 {
    // Read kubeconfig from env
    kubeconfig = os.Getenv(clientcmd.RecommendedConfigPathEnvVar)
    if len(kubeconfig) <= 0 {
        // Read kubeconfig from home dir
        if home := homedir.HomeDir(); home != "" {
            kubeconfig = filepath.Join(home, ".kube", "config")
        }
    }
}`

Verifying this change

./authority
./authority --kubeconfig=/Users/jun/.kube/config_kind --plain-server-port=30061
DUBBO_PLAIN_SERVER_PORT=30061; ./authority
KUBECONFIG=/Users/jun/.kube/config_kind;DUBBO_PLAIN_SERVER_PORT=30069; ./authority --plain-server-port=30061

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

github-advanced-security[bot] commented 1 year ago

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1040 (240e91f) into refactor-with-go (4927fe2) will increase coverage by 0.21%. The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1040      +/-   ##
====================================================
+ Coverage             63.66%   63.88%   +0.21%     
====================================================
  Files                    29       29              
  Lines                  2323     2323              
====================================================
+ Hits                   1479     1484       +5     
+ Misses                  746      742       -4     
+ Partials                 98       97       -1

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more