apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

fix: some bugs in DynamicConfig #1049

Closed ev1lQuark closed 1 year ago

ev1lQuark commented 1 year ago

What is the purpose of the change

Brief changelog

XXXX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

github-advanced-security[bot] commented 1 year ago

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1049 (6bf64c5) into refactor-with-go (6f1e816) will decrease coverage by 0.11%. The diff coverage is 95.00%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1049      +/-   ##
====================================================
- Coverage             65.12%   65.02%   -0.11%     
====================================================
  Files                    27       27              
  Lines                  1967     1967              
====================================================
- Hits                   1281     1279       -2     
- Misses                  591      593       +2     
  Partials                 95       95              
Impacted Files Coverage Δ
pkg/admin/services/override_service_impl.go 48.88% <95.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information