apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
4k stars 2.17k forks source link

[refactor-with-go] without a definite log specification #1057

Open ev1lQuark opened 1 year ago

ev1lQuark commented 1 year ago

In the refactor-with-go branch, the zap log library is configured in the pkg/logger package, but the log information is not printed correctly through zap in some existing services. It is suggested that the community can unify the log specification of dubbo-admin-go, especially the log information of Error level output in error handling.

refactor-with-go 分支中,pkg/logger 包内配置了 zap 日志库,但是已有的部分 services 内并没有通过 zap 正确打印日志信息。建议社区可以统一 dubbo-admin-go 的日志规范,尤其是错误处理中通过 Error 级别的日志打印错误 message。

This is a proposal about log specification of dubbo-admin-go.

AlbumenJ commented 1 year ago

Agree! Would you please try submit a proposal about this?

ev1lQuark commented 1 year ago

Agree! Would you please try submit a proposal about this?

Should I submit a proposal in this issue or somewhere else?

AlbumenJ commented 1 year ago

Agree! Would you please try submit a proposal about this?

Should I submit a proposal in this issue or somewhere else?

Both are acceptable

ev1lQuark commented 1 year ago

This is a proposal about log specification of dubbo-admin-go.

AlbumenJ commented 1 year ago

Totally agree with @ev1lQuark

BTW