apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

Update authorization rule #1061

Closed AlbumenJ closed 1 year ago

AlbumenJ commented 1 year ago

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

github-advanced-security[bot] commented 1 year ago

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov-commenter commented 1 year ago

Codecov Report

Merging #1061 (99b21e2) into refactor-with-go (a08d6b2) will increase coverage by 3.16%. The diff coverage is 98.55%.

:exclamation: Current head 99b21e2 differs from pull request most recent head 0adb033. Consider uploading reports for the commit 0adb033 to get more accurate results

@@                 Coverage Diff                  @@
##           refactor-with-go    #1061      +/-   ##
====================================================
+ Coverage             60.62%   63.79%   +3.16%     
====================================================
  Files                    27       29       +2     
  Lines                  2131     2323     +192     
====================================================
+ Hits                   1292     1482     +190     
- Misses                  742      744       +2     
  Partials                 97       97              
Impacted Files Coverage Δ
pkg/authority/rule/authorization/rule.go 96.21% <97.41%> (+5.73%) :arrow_up:
pkg/authority/rule/authentication/definition.go 100.00% <100.00%> (ø)
pkg/authority/rule/authentication/rule.go 96.21% <100.00%> (-0.27%) :arrow_down:
pkg/authority/rule/authorization/definition.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more