apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

support promethues http_sd discovery #1065

Closed sjmshsh closed 1 year ago

sjmshsh commented 1 year ago

What is the purpose of the change

support promethues http_sd discovery

Brief changelog

I provide an interface for Prometheus to perform service discovery in the form of http_sd

Verifying this change

I wrote some test demos myself to verify that it works

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

github-advanced-security[bot] commented 1 year ago

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1065 (5d41542) into refactor-with-go (c7ed4c6) will decrease coverage by 0.76%. The diff coverage is 0.00%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1065      +/-   ##
====================================================
- Coverage             63.82%   63.07%   -0.76%     
====================================================
  Files                    29       29              
  Lines                  2325     2348      +23     
====================================================
- Hits                   1484     1481       -3     
- Misses                  744      769      +25     
- Partials                 97       98       +1     
Impacted Files Coverage Δ
pkg/admin/services/prometheus_service_impl.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more