fix unlock in refresh server cert

apache / dubbo-admin

The ops and reference implementation for Apache Dubbo

https://dubbo.apache.org

Apache License 2.0

3.99k stars 2.17k forks source link

fix unlock in refresh server cert #1068

Closed 2456868764 closed 1 year ago

2456868764 commented 1 year ago

What is the purpose of the change

fix unlock bug in refresh server cert func.

Brief changelog

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

github-advanced-security[bot] commented 1 year ago

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1068 (08b72bd) into refactor-with-go (5bc791a) will increase coverage by 6.36%. The diff coverage is 75.00%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1068      +/-   ##
====================================================
+ Coverage             63.31%   69.67%   +6.36%     
====================================================
  Files                    32       30       -2     
  Lines                  2622     2361     -261     
====================================================
- Hits                   1660     1645      -15     
+ Misses                  844      600     -244     
+ Partials                118      116       -2

Impacted Files	Coverage Δ
pkg/authority/cert/storage.go	`78.04% <75.00%> (+2.74%)`	:arrow_up:

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more