apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
4k stars 2.17k forks source link

Prometheus http_sd discovery and unit test #1070

Closed sjmshsh closed 1 year ago

sjmshsh commented 1 year ago

why 22222 int pkg/admin/util/monitor_utils.go? ans: After communicating with the relevant person in charge, he asked me to write 22222 to death first, and the follow-up monitoring port will be put into the registration center.

github-advanced-security[bot] commented 1 year ago

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1070 (1217a0e) into refactor-with-go (8e28727) will increase coverage by 0.10%. The diff coverage is 78.57%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1070      +/-   ##
====================================================
+ Coverage             69.46%   69.56%   +0.10%     
====================================================
  Files                    30       31       +1     
  Lines                  2361     2389      +28     
====================================================
+ Hits                   1640     1662      +22     
- Misses                  604      608       +4     
- Partials                117      119       +2     
Impacted Files Coverage Δ
pkg/admin/services/prometheus_service_impl.go 12.87% <73.91%> (+12.87%) :arrow_up:
pkg/admin/util/monitor_utils.go 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

AlbumenJ commented 1 year ago

@chickenlj PTAL