apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

Modify service return format #1092

Closed wudong5 closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #1092 (bd35f9f) into refactor-with-go (f3ced2e) will decrease coverage by 0.15%. The diff coverage is 11.76%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1092      +/-   ##
====================================================
- Coverage             59.10%   58.96%   -0.15%     
====================================================
  Files                    47       47              
  Lines                  3932     3945      +13     
====================================================
+ Hits                   2324     2326       +2     
- Misses                 1384     1395      +11     
  Partials                224      224              
Impacted Files Coverage Δ
pkg/admin/services/consumer_service_impl.go 0.00% <0.00%> (ø)
pkg/admin/util/sync_utils.go 23.85% <0.00%> (-2.41%) :arrow_down:
pkg/dubboctl/internal/manifest/render/render.go 70.10% <ø> (ø)
pkg/admin/services/provider_service_impl.go 47.85% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

chickenlj commented 1 year ago

I have merged your changes into #1121 and resolved the conflicts. Your contribution will be recorded there also.