apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

dubboctl enhancement #1095

Closed DMwangnima closed 1 year ago

DMwangnima commented 1 year ago

What is the purpose of the change

Enhance dubboctl based on initial phase.

Brief changelog

Implement manifest diff and manifest uninstall. Add some log sentences. Fix manifest generate cmd.

Verifying this change

See /pkg/dubboctl/cmd/manifest_test.go

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov-commenter commented 1 year ago

Codecov Report

Merging #1095 (25d602e) into refactor-with-go (f3ced2e) will increase coverage by 0.41%. The diff coverage is 69.58%.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1095      +/-   ##
====================================================
+ Coverage             59.10%   59.51%   +0.41%     
====================================================
  Files                    47       47              
  Lines                  3932     4108     +176     
====================================================
+ Hits                   2324     2445     +121     
- Misses                 1384     1421      +37     
- Partials                224      242      +18     
Impacted Files Coverage Δ
pkg/dubboctl/internal/operator/operator.go 0.00% <0.00%> (ø)
pkg/dubboctl/internal/kube/client.go 48.20% <46.15%> (-1.23%) :arrow_down:
pkg/dubboctl/internal/operator/component.go 62.82% <47.82%> (-1.07%) :arrow_down:
pkg/dubboctl/internal/util/yaml.go 50.00% <85.71%> (+50.00%) :arrow_up:
pkg/dubboctl/internal/kube/object.go 83.33% <96.87%> (+11.27%) :arrow_up:
pkg/dubboctl/cmd/manifest.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more