optimize makefile - Githubissues

2456868764 commented 1 year ago

What is the purpose of the change

update makefile refer to #1107 #1115

Brief changelog

update makefile

make help

manifests Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. generate Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations. dubbo-admin-swagger Generate dubbo-admin swagger docs. fmt Run gofumpt against code vet Run go vet against code. lint Run golang lint against code test Run all tests. test-dubboctl Run tests for dubboctl test-admin Run tests for admin test-authority Run tests for authority build Build binary with the dubbo admin, authority, and dubboctl build-admin Build binary with the dubbo admin. build-authority Build binary with the dubbo authority. build-dubboctl Build binary with the dubbo dubboctl. build-ui Build the distribution of the admin ui pages. image Build docker image with the dubbo admin, authority and admin-ui image-admin Build docker image with the dubbo admin. image-authority Build docker image with the dubbo authority. image-ui Build docker image with the dubbo admin ui. buildx Build and push docker cross-platform image for the dubbo admin and authority buildx-admin Build and push docker image with the dubbo admin for cross-platform support buildx-authority Build and push docker image with the dubbo authority for cross-platform support buildx-dubboctl Build the dubboctl distribution for cross-platform support push-image-admin Push admin images. push-image-authority Push authority images. push-image-ui Push admin ui images. kustomize Download kustomize locally if necessary. If wrong version is installed, it will be removed before downloading. controller-gen Download controller-gen locally if necessary. If wrong version is installed, it will be overwritten. swagger-install Download swagger locally if necessary. golangci-lint-install Download golangci lint locally if necessary. gofumpt-install Download gofumpt lint locally if necessary.
make buildx-dubboctl generate cross-platform as follow in bin/dubboctl directory

.
├── darwin
│   ├── amd64
│   │   └── dubboctl
│   └── arm64
│       └── dubboctl
├── dubboctl-1.0.0-linux-amd64.tar.gz
├── dubboctl-1.0.0-linux-arm64.tar.gz
├── dubboctl-1.0.0-osx-arm64.tar.gz
├── dubboctl-1.0.0-osx.tar.gz
├── dubboctl-1.0.0-win.zip
├── linux
│   ├── amd64
│   │   └── dubboctl
│   └── arm64
│       └── dubboctl
└── windows
    └── amd64
        └── dubboctl.exe

make build-ui auto generate dubbo-admin-ui dist to cmd/ui/dist directory

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1145 (392d5d7) into refactor-with-go (e631dc2) will decrease coverage by 2.14%. The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1145      +/-   ##
====================================================
- Coverage             50.51%   48.37%   -2.14%     
====================================================
  Files                    99      101       +2     
  Lines                  4989     5251     +262     
  Branches                 41       41              
====================================================
+ Hits                   2520     2540      +20     
- Misses                 2210     2450     +240     
- Partials                259      261       +2

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e631dc2...392d5d7. Read the comment docs.