Closed sjmshsh closed 1 year ago
Please fix the following unit test:
ok github.com/apache/dubbo-admin/pkg/admin/model/util 0.007s coverage: 46.6% of statements
# github.com/apache/dubbo-admin/pkg/admin/services [github.com/apache/dubbo-admin/pkg/admin/services.test]
Error: pkg/admin/services/prometheus_service_impl_test.go:153:12: assignment mismatch: 1 variable but prometheusService.PromDiscovery returns 2 values
Kudos, SonarCloud Quality Gate passed!
Merging #1151 (d18e443) into refactor-with-go (de6f94b) will decrease coverage by
0.07%
. The diff coverage is13.33%
.
@@ Coverage Diff @@
## refactor-with-go #1151 +/- ##
====================================================
- Coverage 49.72% 49.65% -0.07%
====================================================
Files 99 99
Lines 5082 5087 +5
Branches 41 41
====================================================
- Hits 2527 2526 -1
- Misses 2296 2302 +6
Partials 259 259
Impacted Files | Coverage Δ | |
---|---|---|
pkg/admin/services/prometheus_service_impl.go | 11.59% <13.33%> (-1.19%) |
:arrow_down: |
... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Solved a potential bug. When the searched index does not exist (the abnormality that has not occurred can not be found), there will be a null pointer error. Here is the judgment of whether the data is queried. And supplement and optimize the code related to http_sd.