apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.98k stars 2.17k forks source link

[fix simple refactor] Differentiate between kubuclient and certclient #1205

Closed sjmshsh closed 1 year ago

sjmshsh commented 1 year ago

The concepts of kubeclient and certclient were a bit confusing before. This PR mainly separates them.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1205 (cf91498) into refactor-with-go-components-experimental (887c510) will increase coverage by 0.21%. The diff coverage is 30.43%.

@@                             Coverage Diff                              @@
##           refactor-with-go-components-experimental    #1205      +/-   ##
============================================================================
+ Coverage                                     48.99%   49.21%   +0.21%     
============================================================================
  Files                                           113      113              
  Lines                                          6043     6010      -33     
  Branches                                         41       41              
============================================================================
- Hits                                           2961     2958       -3     
+ Misses                                         2827     2797      -30     
  Partials                                        255      255              
Impacted Files Coverage Δ
pkg/core/cert/provider/client.go 0.00% <0.00%> (-1.39%) :arrow_down:
pkg/core/cert/provider/storage.go 4.67% <0.00%> (ø)
pkg/authority/server/authority.go 50.00% <50.00%> (ø)
pkg/core/election/kube/leaderelection.go 85.71% <75.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information