apache / dubbo-admin

The ops and reference implementation for Apache Dubbo
https://dubbo.apache.org
Apache License 2.0
3.99k stars 2.17k forks source link

image.registry not being respect #1282

Closed zyue110026 closed 3 weeks ago

zyue110026 commented 1 month ago

We have noticed an instance of incorrect helming in one of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

image.registry does not take effect when changed to a value other than default value 'docker.io'. This is due to missing implementation for this value in helm charts deploy.yaml file:

https://github.com/apache/dubbo-admin/blob/7bca862a7d13d7f20ce415b15bfa71d4ead88d16/charts/dubbo-admin/templates/deploy.yaml#L25

Environment

Steps to reproduce this issue

  1. change the value of image.registry in values.yaml file
  2. using helm chart to deploy

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

change image.registry can take affect, or delete image.registry from values.yaml file

Actual Result

image.registry always be 'docker.io'

If there is an exception, please attach the exception trace:

Just put your stack trace here!