search

apache / dubbo-getty

a netty like asynchronous network I/O library based on tcp/udp/websocket; a bidirectional RPC framework based on JSON/Protobuf; a microservice framework based on zookeeper/etcd
Apache License 2.0
218 stars 69 forks source link

remove read buffer collection #76

Closed LaurenceLiZhixin closed 2 years ago

LaurenceLiZhixin commented 2 years ago

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 2 years ago

Codecov Report

Merging #76 (fb96d44) into master (917228c) will decrease coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   69.14%   69.05%   -0.09%     
==========================================
  Files           8        8              
  Lines        1426     1422       -4     
==========================================
- Hits          986      982       -4     
  Misses        347      347              
  Partials       93       93
Impacted Files Coverage Δ
session.go 70.02% <100.00%> (-0.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 917228c...fb96d44. Read the comment docs.

cnlas commented 2 years ago

bufp is still acquired from pool, why del the defer in second comit?