search

apache / dubbo-getty

a netty like asynchronous network I/O library based on tcp/udp/websocket; a bidirectional RPC framework based on JSON/Protobuf; a microservice framework based on zookeeper/etcd
Apache License 2.0
218 stars 69 forks source link

Opt: change timeout to atomic #80

Closed Lvnszn closed 2 years ago

Lvnszn commented 2 years ago

What this PR does: When high level open many goroutine write pkg to single connection, the timeout will be modified when other user is requesting server. Which issue(s) this PR fixes:

Fixes #60

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 2 years ago

Codecov Report

Merging #80 (71b7f8e) into master (d58f9f3) will not change coverage. The diff coverage is 75.00%.

:exclamation: Current head 71b7f8e differs from pull request most recent head 42bebfd. Consider uploading reports for the commit 42bebfd to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files           8        8           
  Lines        1422     1422           
=======================================
  Hits          980      980           
  Misses        347      347           
  Partials       95       95
Impacted Files Coverage Δ
connection.go 79.73% <73.52%> (ø)
session.go 69.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d58f9f3...42bebfd. Read the comment docs.

Lvnszn commented 2 years ago

@LaurenceLiZhixin @justxuewei PTAL