Closed Lvnszn closed 2 years ago
Merging #86 (de68c22) into master (66e083f) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 8 8
Lines 1439 1439
=======================================
Hits 995 995
Misses 348 348
Partials 96 96
Impacted Files | Coverage Δ | |
---|---|---|
logger.go | 16.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 66e083f...de68c22. Read the comment docs.
这个库是 dubb-go 的底层库,所以不要引用 dubbo-go 的库, "dubbo.apache.org/dubbo-go/v3/common/logger" 这种形式的东西去掉,否则很容易造成循环依赖。你可以看下 “https://github.com/dubbogo/gost/blob/master/log/logger.go” 是否满足你的需要,如果不满足,可以去改进 dubbo-go 和 dubbo-getty 的共同的基础库 gost
这个库是 dubb-go 的底层库,所以不要引用 dubbo-go 的库, "dubbo.apache.org/dubbo-go/v3/common/logger" 这种形式的东西去掉,否则很容易造成循环依赖。你可以看下 “https://github.com/dubbogo/gost/blob/master/log/logger.go” 是否满足你的需要,如果不满足,可以去改进 dubbo-go 和 dubbo-getty 的共同的基础库 gost
调整了一版本,用了getty里面的logger,只要不注入logger的实例会用默认的zap log。PLAT @AlexStocks
What this PR does: Change from log4go to dubbogo log lib Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: