search

apache / dubbo-getty

a netty like asynchronous network I/O library based on tcp/udp/websocket; a bidirectional RPC framework based on JSON/Protobuf; a microservice framework based on zookeeper/etcd
Apache License 2.0
218 stars 69 forks source link

Fix: taskPool will execute task when session was nil #91

Closed Lvnszn closed 2 years ago

Lvnszn commented 2 years ago

What this PR does: First task was be added into task pool, then session will be set to nil with connection interrupted and task was executed by goroutine will lead to panic. Which issue(s) this PR fixes:

Fixes #88

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 2 years ago

Codecov Report

Merging #91 (d25d2a8) into master (76136d0) will decrease coverage by 0.05%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   69.14%   69.09%   -0.06%     
==========================================
  Files           8        8              
  Lines        1439     1443       +4     
==========================================
+ Hits          995      997       +2     
- Misses        348      349       +1     
- Partials       96       97       +1
Impacted Files Coverage Δ
session.go 69.66% <50.00%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76136d0...d25d2a8. Read the comment docs.