search

apache / dubbo-go-hessian2

caucho hessian2 implementation in Go for [apache/dubbo-go](https://github.com/apache/dubbo-go) which is compatible with [dubbo-hessian-lite](https://github.com/apache/dubbo-hessian-lite)
Apache License 2.0
209 stars 113 forks source link

some issues needed to fix for v1.5.0 #177

Closed wongoo closed 4 years ago

wongoo commented 4 years ago

What would you like to be added:

  1. appendix in LICENSE

  2. update the dependency libs with them latest version in go.mod:

    • github.com/dubbogo/gost v1.8.0
    • github.com/pkg/errors v0.9.1
    • github.com/stretchr/testify v1.5.1

  3. add comment for public struct/functions in

    • java_collection.go
    • request.go
    • serialize.go
AlexStocks commented 4 years ago

In the voting mail of dubbo-go-hessian2 v1.5.0, Mr Justin said "LICENSE is missing the appendix. Please fix this."

Indeedly, compared to the license of dubbo-go, the license of this project is lack of the following sentences,

APPENDIX: How to apply the Apache License to your work.

      To apply the Apache License to your work, attach the following
      boilerplate notice, with the fields enclosed by brackets "[]"
      replaced with your own identifying information. (Don't include
      the brackets!)  The text should be enclosed in the appropriate
      comment syntax for the file format. We also recommend that a
      file or class name and description of purpose be included on the
      same "printed page" as the copyright notice for easier
      identification within third-party archives.

   Copyright [yyyy] [name of copyright owner]

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
micln commented 4 years ago

something wrong, github.com/stretchr/testify v1.5.1 need Go 1.13+

https://github.com/stretchr/testify/blob/v1.5.1/go.mod#L10

https://travis-ci.org/github/apache/dubbo-go-hessian2/builds/687823542?utm_source=github_status&utm_medium=notification