apache / dubbo-go-pixiu

Based on the proxy gateway service of dubbo-go, it solves the problem that the external protocol calls the internal Dubbo cluster. At present, it supports HTTP and gRPC[developing].
https://dubbogo.github.io/dubbo-go-proxy/
Apache License 2.0
476 stars 149 forks source link

upgrade dubbogo version: 3.1.0 #603

Closed hookokoko closed 8 months ago

hookokoko commented 9 months ago

What this PR does: upgrage dubbogo to 3.1.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: 应该还要依赖dubbogo的一些修改

  1. 依赖的dubbogo的health.proto的pakagename冲突(protocol/triple/health/triple_health/health.proto)
  2. dubbogo中的registryUrl.Protocol的问题(registry/protocol/protocol.go) Does this PR introduce a user-facing change?:
hookokoko commented 9 months ago
func (proto *registryProtocol) Refer(url *common.URL) protocol.Invoker {
    ......
    if registryUrl.Protocol == constant.RegistryProtocol {
        registryUrl.Protocol = registryUrl.GetParam(constant.RegistryKey, "")
    }
        ......

在跑pixiu sample中的body例子时,dubbogo 3.1.0版本中会将registryUrl.Protocol设置为service-discovery-registry,上面if分支中应该需要额外一个判断: if registryUrl.Protocol == constant.RegistryProtocol || registryUrl.Protocol == "service-discovery-registry" {...} 不然找不到registry对象

baerwang commented 9 months ago

pls fix ci

baerwang commented 9 months ago

看下为什么找不到依赖 @hookokoko https://github.com/apache/dubbo-go-pixiu/actions/runs/7323061542/job/19956310498?pr=603

hookokoko commented 9 months ago

看下为什么找不到依赖 @hookokoko https://github.com/apache/dubbo-go-pixiu/actions/runs/7323061542/job/19956310498?pr=603

dubbo-pixiu-sample使用的dubbo版本也需要升级一下,3.1.0的dubbogo没dubbo.apache.org/dubbo-go/v3/common/logger

hookokoko commented 9 months ago

很奇怪,commit的时候看着ci是通过了。不过,按道理integrate test那里应该都过不去哇

mark4z commented 9 months ago

@mark4z

baerwang commented 8 months ago

pls fix conflicts,bro

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud