search

apache / dubbo-go

Go Implementation For Apache Dubbo .
https://dubbo.apache.org/
Apache License 2.0
4.69k stars 917 forks source link

Fix/retry opt (#2598) #2601

Closed Phixsura closed 6 months ago

Phixsura commented 7 months ago

fix https://github.com/apache/dubbo-go/issues/2598 Currently, failover has been fixed, and failback will be fixed later.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.54%. Comparing base (f30b47b) to head (8054ddc).

:exclamation: Current head 8054ddc differs from pull request most recent head 10166d7. Consider uploading reports for the commit 10166d7 to get more accurate results

Files Patch % Lines
cluster/cluster/failover/cluster_invoker.go 75.00% 1 Missing and 1 partial :warning:
cluster/cluster/failback/cluster_invoker.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev-3.3 #2601 +/- ## =========================================== - Coverage 47.74% 47.54% -0.20% =========================================== Files 304 318 +14 Lines 22725 23632 +907 =========================================== + Hits 10849 11237 +388 - Misses 10838 11334 +496 - Partials 1038 1061 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Phixsura commented 7 months ago

PTAL @chickenlj @justxuewei