Closed CrazyHZM closed 5 years ago
Merging #8 into master will increase coverage by
0.21%
. The diff coverage is88.23%
.
@@ Coverage Diff @@
## master #8 +/- ##
============================================
+ Coverage 24.24% 24.46% +0.21%
- Complexity 455 460 +5
============================================
Files 89 89
Lines 6289 6302 +13
Branches 1048 1048
============================================
+ Hits 1525 1542 +17
+ Misses 4547 4545 -2
+ Partials 217 215 -2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../com/caucho/hessian/io/CollectionDeserializer.java | 73.07% <100%> (+5.68%) |
14 <3> (+2) |
:arrow_up: |
...m/alibaba/com/caucho/hessian/io/Hessian2Input.java | 19.69% <71.42%> (+0.65%) |
64 <8> (+2) |
:arrow_up: |
.../alibaba/com/caucho/hessian/io/Hessian2Output.java | 24.43% <0%> (+0.51%) |
33% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5bcfcf4...42ff241. Read the comment docs.
Please see the java7 error https://travis-ci.org/dubbo/hessian-lite/jobs/506137514
Please see the java7 error https://travis-ci.org/dubbo/hessian-lite/jobs/506137514
I will look later, because I don't have a java7 environment yet, would you give me some advice?
I will look later, because I don't have a java7 environment yet, would you give me some advice?
I think you can setup a java7 in your pc
Additional, please add some test case to verify your change for the issue: https://github.com/apache/incubator-dubbo/issues/3640
I will look later, because I don't have a java7 environment yet, would you give me some advice?
I think you can setup a java7 in your pc
Additional, please add some test case to verify your change for the issue: apache/incubator-dubbo#3640
Yes,I will add test case later.
I will look later, because I don't have a java7 environment yet, would you give me some advice?
I think you can setup a java7 in your pc
Additional, please add some test case to verify your change for the issue: apache/incubator-dubbo#3640
I tested it in java7 in my local environment and found that it was passed. I don’t have any ideas for now. Let’s take another look.
LGTM
这逻辑根本不对,多线程的时候,直接报错。
修复https://github.com/apache/incubator-dubbo/issues/3640 问题