search

apache / dubbo-js

The Typescript implementation of Apache Dubbo. An RPC and microservice framework for Node.js and Web development.
https://dubbo.apache.org/
Apache License 2.0
767 stars 160 forks source link

Make it subscribing all possible targets when set version to '*' or empty #129

Closed jasonjoo2010 closed 5 years ago

jasonjoo2010 commented 5 years ago

Version should be an optional value and compatible with Dubbo's wildcard gramma '*'.

Reference to #126

jasonjoo2010 commented 5 years ago

I am not a node.js expert, but this look good to me.

And we have already published it into a alias repository: https://www.npmjs.com/package/@yoloho/dubbo-js

Yet everything seems good and we can get rid of version=0.0.0 finally.

ralf0131 commented 5 years ago

And we have already published it into a alias repository: https://www.npmjs.com/package/@yoloho/dubbo-js

Please do not do this. dubbo-js is an Apache Dubbo project, has it own branding policy. You may in the way of infringing Dubbo's brand. Please wait for the official project to publish the arthifact.

Yet everything seems good and we can get rid of version=0.0.0 finally.

Let me merge it.

jasonjoo2010 commented 5 years ago

Please wait for the official project to publish the arthifact.

Because we have two project affected wait to deploy. But now I indeed have trouble to remove the package from npmjs.org..............

I have noticed what you said and will pay attention in future.

Thanks

jasonjoo2010 commented 5 years ago

And more may I ask the schedule of dubbo-js@3.0.0 (which the old package name is dubbo2.js)?

ralf0131 commented 5 years ago

Please wait for the official project to publish the arthifact.

Because we have two project affected wait to deploy. But now I indeed have trouble to remove the package from npmjs.org..............

I have noticed what you said and will pay attention in future.

Thanks

It's okay as long as you deprecate it.

ralf0131 commented 5 years ago

And more may I ask the schedule of dubbo-js@3.0.0 (which the old package name is dubbo2.js)?

Yes, there is a plan to release, maybe @hufeng could explain the details.