apache / dubbo-proxy

Apache dubbo
https://dubbo.apache.org/
258 stars 86 forks source link

在当前master(2.7.5-snapshot)分支中demo模块启动失败,请关注AbstractInterfaceConfig该类实现 #23

Open jisuwoniu opened 4 years ago

jisuwoniu commented 4 years ago

https://github.com/apache/dubbo/blob/master/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java

对比2.7.4中release代码发现当前master(2.7.5-snapshot)存在bug, `

           ConfigManager configManager = ConfigManager.getInstance();
            ConfigCenterConfig cc = (ConfigCenterConfig)configManager.getConfigCenter().orElse(new ConfigCenterConfig());
            if (rc.getParameters() != null) {
                Map<String, String> configParams = cc.getParameters() == null ? new HashMap() : cc.getParameters();
                ((Map)configParams).putAll(rc.getParameters());
                cc.setParameters((Map)configParams);
            } 
            cc.getParameters().put("client", rc.getClient());

`

rc.getParameters()为空的情况下cc.getParameters()为空,导致 cc.getParameters().put("client", rc.getClient());抛空指针

qixiaobo commented 4 years ago

那应该提到dubbo吧 不是在dubboProxy吧