apache / dubbo

The java implementation of Apache Dubbo. An RPC and microservice framework.
https://dubbo.apache.org/
Apache License 2.0
40.53k stars 26.44k forks source link

[Dubbo]: Fix the bug that isDefault configuration is not useful #12961 #14888

Open paradiseidler opened 1 week ago

paradiseidler commented 1 week ago

What is the purpose of the change?

Fix #12961 The tag with attribute=false for the isDefault property has been removed. 1 3

In the isIgnoredAttribute method, due to isDefault having attribute=false, the entire method returns a Boolean value of true.

2

In the assignProperties method of the AbstractConfig class, at the breakpoint, the final condition evaluates to false, preventing the default property assignment process from being executed, resulting in the default value remaining unprocessed as null.

Checklist

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 2.20%. Comparing base (ef6e8bd) to head (69de5fb). Report is 56 commits behind head on 3.3.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.3 #14888 +/- ## ============================================= - Coverage 37.53% 2.20% -35.34% ============================================= Files 1813 26083 +24270 Lines 80737 1389674 +1308937 Branches 12005 220210 +208205 ============================================= + Hits 30304 30588 +284 - Misses 46042 1354645 +1308603 - Partials 4391 4441 +50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.