apache / dubbo

The java implementation of Apache Dubbo. An RPC and microservice framework.
https://dubbo.apache.org/
Apache License 2.0
40.52k stars 26.43k forks source link

telnet cannot call the correct overload method #3177

Closed gudegg closed 5 years ago

gudegg commented 5 years ago

Environment

Steps to reproduce this issue

org.apache.dubbo.rpc.protocol.dubbo.support.DemoService add method

 String getPerson(Yee yee);

org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl

    @Override
    public String getPerson(Yee yee) {
        return yee.getAddress();
    }
public class Yee implements Serializable {
    private String address;
}

public class Man implements Serializable {
    private static final long serialVersionUID = 1L;
    private String name;
    private int age;
}

org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl add UT

   @Test
    public void testInvokeMultiJsonParamMethod2() throws RemotingException {
        mockChannel = mock(Channel.class);
        given(mockChannel.getAttribute("telnet.service")).willReturn(null);
        given(mockChannel.getLocalAddress()).willReturn(NetUtils.toAddress("127.0.0.1:5555"));
        given(mockChannel.getRemoteAddress()).willReturn(NetUtils.toAddress("127.0.0.1:20886"));

        ProviderModel providerModel = new ProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService", new DemoServiceImpl(), DemoService.class);
        ApplicationModel.initProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService", providerModel);
        String param = "{\"address\":\"Dubbo\"}";
        String result = invoke.telnet(mockChannel, "getPerson(" + param + ")");
        assertTrue(result.contains("result: \"Dubbo"));
    }
  1. UT fail,Find the wrong overload method

Expected Result

Call getPerson(Yee yee)

Actual Result

Call getPerson(Man man)

Suggestion

If the overload method parameters are different in length, allowed to not pass class parameter, otherwise prompted user must pass the class parameter.

@beiwei30

carryxyh commented 5 years ago

这个issue是已知的,对于重载的支持不好。但是我忘记具体的issue是在哪里了。yiji提交过类似的issue。 @zonghaishang

carryxyh commented 5 years ago

找到了: https://github.com/apache/incubator-dubbo/issues/2766

@gudegg 你可以看下,如果反应的是同一个问题,这个issue就先关掉吧。

LiZhenNet commented 5 years ago

找到了:

2766

@gudegg 你可以看下,如果反应的是同一个问题,这个issue就先关掉吧。

先不要关掉吧,这个问题主要是针对我的一个pr,感觉还有优化的地方。

CrazyHZM commented 5 years ago

先不要关掉吧,这个问题主要是针对我的一个pr,感觉还有优化的地方。

关于哪个pr

carryxyh commented 5 years ago

先不要关掉吧,这个问题主要是针对我的一个pr,感觉还有优化的地方。

@LiZhenNet 好的。

kexianjun commented 5 years ago

In this case, maybe specific parameter types is needed.

tswstarplanet commented 5 years ago

I find that it is not an easy thing that support telnet perfectly.