search

apache / dubbo

The java implementation of Apache Dubbo. An RPC and microservice framework.
https://dubbo.apache.org/
Apache License 2.0
40.5k stars 26.43k forks source link

[Issue] Qos port can't be disabled by externalized property #3958

Closed mercyblitz closed 5 years ago

mercyblitz commented 5 years ago

Dubbo's Qos port can't be disabled by dubbo.application.qos-enable=false

Moriadry-zz commented 5 years ago

Does it because we lost the QOS_ENABLE parameter in RegistryProtocol.getRegisteredProviderUrl method ? a little guess

tswstarplanet commented 5 years ago

@mercyblitz I test the configuration using incubator-dubbo-spring-boot-project, and I find it can disable the Qos using dubbo.application.qos-enable=false.

tswstarplanet commented 5 years ago

I use the sample in the incubator-dubbo-spring-boot-project to test

wangwengeek commented 5 years ago

我看官网 qos最下面又变成这样配置了试了一下管用 dubbo.application.qosEnable=true dubbo.application.qosPort=33333 dubbo.application.qosAcceptForeignIp=false

chickenlj commented 5 years ago

I also cannot reproduce the problem, dubbo.application.qos-enable=false works for boot-starter.

chickenlj commented 5 years ago

But I think we should unify the the property name used in boot-starter and the core framework.