The judgment condition for the AccessLogFilter print log is incorrect.

[wangyanrui]

• [x] I have searched the issues of this repository and believe that this is not a duplicate.
• [x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

• Dubbo version: 2.7.3
• Operating System version: Window10
• Java version: 1.8

Steps to reproduce this issue

1. open AccessLogFilter

   dubbo:
   scan:
   base-packages: ...
   protocol:
   name: dubbo
   port: 12345
   registry:
   address: N/A
   provider:
   accesslog: true

2. org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper#buildInvokerChain return the AccessLogFilter success
3. org.apache.dubbo.rpc.filter.AccessLogFilter#invoke

   String accessLogKey = invoker.getUrl().getParameter(ACCESS_LOG_KEY);
   if (ConfigUtils.isNotEmpty(accessLogKey)) {
   log......
   }

   invoker.getUrl() not contain parameter who's named 'ACCESS_LOG_KEY' but accesslog. private static final String ACCESS_LOG_KEY = "dubbo.accesslog"; (Line 71 in AccessLogFilter) There is no way to successfully print the log.

[wangyanrui]

It is possible that the way to generate the URL is wrong or or simply the match string mistake, or is it that I am using it incorrectly?

[wangyanrui]

Sorry, It's happened when use dubbo-spring-boot-starter and normal when use xml. I have already raised this question in the corresponding project, need to close it here?

[CrazyHZM]

It has been fixed

[wangyanrui]

Can you tell me when and what version fixes it? tks,tks

[CrazyHZM]

The next version will be fixed, the specific time has not been determined, if it is urgent, you can refer to this part of the change #4566

[wangyanrui]

The judgment condition is "accesslog", but the matching content is still "dubbo.accesslog" in the fixed. Are you sure that this problem is fixed? Or is it wrong with me???

[CrazyHZM]

‘dubbo.accesslog’ and ‘ accesslog’ have different meanings, you can refer to this article： http://dubbo.apache.org/en-us/docs/user/demos/accesslog.html

[wangyanrui]

The parameters in the URL are "accesslog=true" Whether to print the log is based on whether the URL contains the "dubbo.accesslog" parameter

It's always false, Maybe we are not talking about one thing!!

[CrazyHZM]

You can update your code and see the latest code on the master. see org.apache.dubbo.rpc.Constants.ACCESS_LOG_KEY

[wangyanrui]

What you are saying is whether to open this filter and I am saying whether to print the log = =

[CrazyHZM]

This is the latest code, if you still have questions, you can add my contact WeChat：15869687598 private static final String LOG_KEY = "dubbo.accesslog";